Add 'strict' mode #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This raises TemplateExecutionException if reference does not exist in content. It's even stricter than Velocity's "strict mode", that accepts undefined variables (in special cases) in #if blocks.
|
Thanks! Thinking about this, I guess another way to do it might be to support a well-known object in the namespace, e.g. |
|
Yeah, that would work, too. It would kinda feel dirty to pollute user's namespace, but I guess there's no harm so why not. I can change it. Any other changes you'd like to see here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sketched something for #39.
loaderas vessel to deliveroptions. Not perfect, but should work.What do you think? Do you see fundamental problems here?